Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lumen console to artisan #2202

Merged
merged 11 commits into from
Nov 14, 2017
Merged

Lumen console to artisan #2202

merged 11 commits into from
Nov 14, 2017

Conversation

rjmackay
Copy link
Contributor

@rjmackay rjmackay commented Oct 23, 2017

This pull request makes the following changes:

  • Remove old command and console application
  • Move import command to artisan
  • Fix up mergeing defaults into config
  • Move notifications and saved search commands into artisan
  • Move webhook command to artisan
  • Move user:create/delete to artisan
  • Move dataprovider commands to artisan
  • Move config:get/set commands into artisan

Test checklist:

  • Run ./artisan
  • Run ./bin/ushahidi
  • Run ./artisan config:get
  • Run ./artisan config:set ...
  • Run ./artisan dataprovider:incoming
  • Run ./artisan dataprovider:outgoing
  • Run ./artisan user:create
  • Run ./artisan user:delete
  • Run ./artisan savedsearch:sync
  • Run ./artisan notification:queue
  • Run ./artisan webhook:send
  • Run ./artisan export (Doesn't appear to work yet?)

Refs #1372

Ping @ushahidi/platform

@rjmackay rjmackay requested a review from willdoran October 23, 2017 03:09
@rjmackay rjmackay requested a review from rowasc October 29, 2017 22:58
@rjmackay rjmackay mentioned this pull request Oct 29, 2017
13 tasks
@rjmackay rjmackay force-pushed the lumen-console-to-artisan branch from 667258b to db1261e Compare October 29, 2017 23:27
@rjmackay
Copy link
Contributor Author

@rowasc @willdoran did the post exporter CLI command work in the main branch? I'm getting no output

@rjmackay rjmackay force-pushed the lumen branch 2 times, most recently from 027fd2b to 05ae30f Compare October 30, 2017 08:26
@rowasc
Copy link
Contributor

rowasc commented Oct 30, 2017

@rjmackay Robbie, it should. :/ I exported about 50k rows last week with it. Only thing is that it goes up to 10k rows or so and then dies. So you will want to use the limit and offsets

@rjmackay rjmackay force-pushed the lumen-console-to-artisan branch from db1261e to facca1b Compare October 30, 2017 22:51
@rjmackay
Copy link
Contributor Author

Fixed with the latest lumen

@kinstella
Copy link
Contributor

kinstella commented Oct 31, 2017

All of the commands above are running, but are there specific inputs/outputs to be tested? e.g.:
./artisan config:get site
./artisan config:get features ,
./artisan user:create --realname=someperson --email=someone@example.com

@rjmackay rjmackay merged commit e9ad334 into lumen Nov 14, 2017
@rjmackay rjmackay deleted the lumen-console-to-artisan branch May 9, 2018 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants