API should not support adding child categories with different permission than parent #2481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowasc
changed the title
rowasc
commented
Feb 19, 2018
| @@ -162,8 +160,30 @@ public function delete(Entity $entity) | |||
| public function deleteTag($id) | |||
| { | |||
| // Remove tag from attribute options | |||
| $this->removeTagFromAttributeOptions($entity->id); | |||
|
|
|||
| $this->removeTagFromAttributeOptions($id); | |||
There was a problem hiding this comment.
I'm really not sure why this was using $entity->id since there was not entity to use. I could revert it .. it's probably not being used . :/
There was a problem hiding this comment.
Hmmm yeah this must not have been used anymore
|
@willdoran can you take a look at this PR? I'm not sure TBH, I think isRoleValid could move to a trait and have a better name, (besides the implementation itself) ?? |
willdoran
reviewed
Feb 19, 2018
| @@ -162,8 +160,30 @@ public function delete(Entity $entity) | |||
| public function deleteTag($id) | |||
| { | |||
| // Remove tag from attribute options | |||
| $this->removeTagFromAttributeOptions($entity->id); | |||
|
|
|||
| $this->removeTagFromAttributeOptions($id); | |||
There was a problem hiding this comment.
Hmmm yeah this must not have been used anymore
willdoran
approved these changes
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
Test checklist:
[ ]
I certify that I ran my checklist
Fixes ushahidi/platform# .
Ping @ushahidi/platform