fix(category permissions) role must match for child and parent #2486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowasc
commented
Feb 20, 2018
| @@ -174,12 +174,13 @@ public function deleteTag($id) | |||
| public function isRoleValid(Validation $validation, $fullData) | |||
| { | |||
| $valid = true; | |||
| $isChild = $fullData['parent_id']; | |||
There was a problem hiding this comment.
@willdoran had to refactor this.
- I had a dumb bug checking $valid incorrectly, I suspect I had tested and then changed something. Aaaanyway. FIxed now
- I realized I needed to use entities otherwise we need to wrangle the fulldata role formats and we really shouldn't need to do that!
- Fixed tests to actually, you know.. test the correct thing.
willdoran
reviewed
Feb 21, 2018
|
@willdoran yep, that's correct . About the warning: IF that happens (when editing children we don't show a way to edit the role, it is always the parent's role) we would send back a message with a 422 that says "Role must match the parent category" (70e91c9#diff-05eed86ed0c3b7db17b92d1d4fbf735a) This was mostly for preventing any type of client bugs with role settings from messing up the database and for preventing postman/ cli based post creation from messing up the category permissions. |
willdoran
approved these changes
Feb 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes:
Test checklist:
Follow checklist in platform/Creating a category should not allow child categories to have different permissions than their parent categories #2408
I certify that I ran my checklist
Fixes ushahidi/platform# .
Ping @ushahidi/platform