Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding fix for Role feature state check #3135

Merged
merged 1 commit into from
Jul 9, 2018
Merged

Adding fix for Role feature state check #3135

merged 1 commit into from
Jul 9, 2018

Conversation

rjmackay
Copy link
Contributor

@rjmackay rjmackay commented Jul 6, 2018

Backporting #2851

Test checklist:

  • With Roles feature enabled set to false
  • Attempt to create/update a new role via HTTP Post
  • You should receive a 422

Refs #3082

Ping @ushahidi/platform

@rjmackay rjmackay requested review from rowasc and willdoran July 6, 2018 01:07
willdoran
willdoran approved these changes Jul 6, 2018
View reviewed changes
Copy link
Contributor

@willdoran willdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also works :D

@rjmackay rjmackay merged commit 0071178 into master Jul 9, 2018
@tuxpiper tuxpiper deleted the rebase-ush022 branch March 24, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willdoran willdoran willdoran approved these changes

@rowasc rowasc Awaiting requested review from rowasc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjmackay @willdoran