-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed links to mapquest terms #4405
Conversation
@@ -40,4 +40,4 @@ Map Data | |||
======== | |||
|
|||
The default map data used comes from OpenStreetMap - <http://osm.org/copyright> | |||
The default imagery comes from MapQuest and is subject to the following terms: <http://developer.mapquest.com/web/info/terms-of-use> and <http://info.mapquest.com/terms-of-use/> | |||
The default imagery comes from MapQuest and is subject to the following terms: <https://developer.mapquest.com/legal> and <https://hello.mapquest.com/terms-of-use> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be helpful to explain why there are two links (not just one) and what they govern in detail ... in case somebody knows ...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @ptandler guess I am still trying to figure it out,
- I noticed one governs the developers ( https://developer.mapquest.com/legal ) and the other governs general terms of use (https://hello.mapquest.com/terms-of-use ) , its still not really that clear to me yet.
hi @webong please whats you take on this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution @andrew21-mch 🙏
@Angamanga - this might be a kind of stupid question: I just realized, that Ushahidi seems to use Mapbox.com, not MapQuest ... so if this is correct, should the license mention MapBox instead? When I do a full-text search in the code, I only find this usage of "mapquest": if (config.default_view.baselayer === 'MapQuest') {
config.default_view.baselayer = 'streets';
}
if (config.default_view.baselayer === 'MapQuestAerial') {
config.default_view.baselayer = 'satellite';
} However, the mapbox API key is mentioned in a couple of places: |
Hi @ptandler thanks, |
Hm, I think this is mainly a legal issue, so someone who understands legal stuff would need to clarify the situation here. I am a developer 😎 |
Alright thanks |
This pull request makes the following changes:
changes links to the mapquest terms
tested link on chrome browser
I certify that I ran my checklist
Fixes #4401
Ping @ushahidi/platform