Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed links to mapquest terms #4405

Closed
wants to merge 2 commits into from

Conversation

andrew21-mch
Copy link

@andrew21-mch andrew21-mch commented Mar 26, 2022

This pull request makes the following changes:

  • changes links to the mapquest terms

  • tested link on chrome browser

  • I certify that I ran my checklist

Fixes #4401

Ping @ushahidi/platform

@@ -40,4 +40,4 @@ Map Data
========

The default map data used comes from OpenStreetMap - <http://osm.org/copyright>
The default imagery comes from MapQuest and is subject to the following terms: <http://developer.mapquest.com/web/info/terms-of-use> and <http://info.mapquest.com/terms-of-use/>
The default imagery comes from MapQuest and is subject to the following terms: <https://developer.mapquest.com/legal> and <https://hello.mapquest.com/terms-of-use>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be helpful to explain why there are two links (not just one) and what they govern in detail ... in case somebody knows ...?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @ptandler guess I am still trying to figure it out,

@andrew21-mch
Copy link
Author

hi @webong please whats you take on this?

Copy link
Contributor

@Angamanga Angamanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @andrew21-mch 🙏

@ptandler
Copy link
Contributor

@Angamanga - this might be a kind of stupid question: I just realized, that Ushahidi seems to use Mapbox.com, not MapQuest ... so if this is correct, should the license mention MapBox instead?

When I do a full-text search in the code, I only find this usage of "mapquest":

            if (config.default_view.baselayer === 'MapQuest') {
                config.default_view.baselayer = 'streets';
            }
            if (config.default_view.baselayer === 'MapQuestAerial') {
                config.default_view.baselayer = 'satellite';
            }

However, the mapbox API key is mentioned in a couple of places: apikey: CONST.MAPBOX_API_KEY,

@andrew21-mch
Copy link
Author

Hi @ptandler thanks,
please what should be done next in this case ?

@ptandler
Copy link
Contributor

Hi @ptandler thanks, please what should be done next in this case ?

Hm, I think this is mainly a legal issue, so someone who understands legal stuff would need to clarify the situation here. I am a developer 😎

@andrew21-mch
Copy link
Author

Hi @ptandler thanks, please what should be done next in this case ?

Hm, I think this is mainly a legal issue, so someone who understands legal stuff would need to clarify the situation here. I am a developer sunglasses

Alright thanks

@webong webong closed this Jun 21, 2022
@andrew21-mch andrew21-mch deleted the patch-1 branch June 25, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links to MapQuest terms broken in LICENSE.md
4 participants