USH-1125: disable arbitrary limitation on CSV import file data size #4816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ushahidlee
reviewed
Mar 12, 2024
| // David Losada update 2024-03-15: originally 20KB, that size is arbitrary and not useful to anyone. | ||
| // Setting to 1TiB, instead | ||
| // Let's make it something reasonable when the work to make this a config value happens. | ||
| return 1024 * 1024 * 1024 * 1024; |
There was a problem hiding this comment.
I think this is a bit high. Can I suggest somewhere in the range of 20mb - 50mb?
tuxpiper
force-pushed
the
ush-1125-csv-limitation
branch
from
de55da4 to
ab1e31b
Compare
Mh-Asmi
approved these changes
Mar 12, 2024
tuxpiper
added a commit
that referenced
this pull request
Mar 12, 2024
tuxpiper
added a commit
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the following changes: