Email Issues #4827
Merged
Email Issues #4827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mh-Asmi
approved these changes
Mar 18, 2024
|
Nice 👌 thank you, @ushahidlee ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a bugfix and new functionality.
Bug: The data source was selecting the last imported message from the platforms database and using its id as the starting point to fetch new messages from the mailbox. This means that if the data source was removed and then re-added, it would use the previously fetched message id as a starting point and not fetch messages until the new messages had ids that exceeded that value. This fix allows the data source to save the last fetch email id in its config, which is deleted with the data source.
New Functionality: I have added a new option to the setup which allows the user to specify whether they would like all email fetched (ie. everything in the inbox irrespective of the number of emails) or only unread email (the new option).