Ush 1164 - Gmail settings #4918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuxpiper
approved these changes
Apr 16, 2024
tuxpiper
pushed a commit
that referenced
this pull request
May 10, 2024
* New functionality and a big bug fix * Added some missing config for tests * Load configrepo in constructor * minor * Small changes to accommodate tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Each visit to a data source settings page, rewrites the entire config for the data source, wiping out any data that isnt included in the form.
Solution
This PR adds a hidden field to store the id of the last retrieved email which will persist even when settings are changed. It works in combination with a frontend PR (ushahidi/platform-client-mzima#1008).
Testing