Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude posts of survey with private locations #4922

Merged
merged 3 commits into from
Apr 25, 2024
Merged

exclude posts of survey with private locations #4922

merged 3 commits into from
Apr 25, 2024

Conversation

Mh-Asmi
Copy link
Contributor

@Mh-Asmi Mh-Asmi commented Apr 22, 2024

This pull request makes the following changes:

  • calculate surveys_with_private_location by it's query in post controler
  • then add these ids as excluded forms to search fields

Test checklist:

  • [ ]

  • I certify that I ran my checklist

Fixes ushahidi/platform# .

Ping @ushahidi/platform

@Mh-Asmi Mh-Asmi requested a review from ushahidlee April 22, 2024 14:04
Copy link
Contributor

@ushahidlee ushahidlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change for better performance.

@Mh-Asmi Mh-Asmi requested a review from ushahidlee April 25, 2024 05:33
Copy link
Contributor

@ushahidlee ushahidlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Mh-Asmi Mh-Asmi merged commit 2325082 into develop Apr 25, 2024
4 checks passed
Copy link

sentry-io bot commented May 1, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Illuminate\Database\QueryException: SQLSTATE[HY000]: General error: 1267 Illegal mix of collations (utf8_general_ci,IMPLICIT) and (ut... Ushahidi\Modules\V5\Http\Controllers\PostContro... View Issue

Did you find this useful? React with a 👍 or 👎

@Mh-Asmi Mh-Asmi deleted the USH-1282 branch May 17, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants