Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ush 1196 #4938

Merged
merged 7 commits into from
Apr 29, 2024
Merged

Ush 1196 #4938

merged 7 commits into from
Apr 29, 2024

Conversation

Mh-Asmi
Copy link
Contributor

@Mh-Asmi Mh-Asmi commented Apr 29, 2024

This pull request makes the following changes:

  • fix the issue of reading the "false" value of include_unstructured_posts
  • fix the issue of including unstructured_posts in the source statistic

Test checklist:

  • [ ]

  • I certify that I ran my checklist

Fixes ushahidi/platform# .

Ping @ushahidi/platform

@linear Linear
Copy link

linear bot commented Apr 29, 2024

USH-1196 Inaccurate post filtering by form : Results include posts outside the specified survey

@Mh-Asmi Mh-Asmi requested a review from ushahidlee April 29, 2024 08:15
ushahidlee
ushahidlee approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@ushahidlee ushahidlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok

@Mh-Asmi Mh-Asmi merged commit cb369dd into develop Apr 29, 2024
4 checks passed
@Mh-Asmi Mh-Asmi deleted the USH-1196 branch May 17, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ushahidlee ushahidlee ushahidlee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mh-Asmi @ushahidlee