Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only parameter for category #5014

Merged
merged 6 commits into from
Nov 27, 2024
Merged

only parameter for category #5014

merged 6 commits into from
Nov 27, 2024

Conversation

Mh-Asmi
Copy link
Contributor

@Mh-Asmi Mh-Asmi commented Nov 19, 2024

This pull request makes the following changes:

Test checklist:

  • [ ]

  • I certify that I ran my checklist

Fixes ushahidi/platform# .

Ping @ushahidi/platform

Copy link

linear bot commented Nov 19, 2024

Copy link
Member

@tuxpiper tuxpiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's quite a bit of change here and I can't seem to be able to get very deep into it, but I think it looks good. Maybe we could write some tests in a pairing session.

@Mh-Asmi Mh-Asmi merged commit 316727f into develop Nov 27, 2024
4 checks passed
Copy link

sentry-io bot commented Nov 27, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: Xdebug has detected a possible infinite loop, and aborted your script with a stack depth of '256'... Ushahidi\Modules\V5\Http\Controllers\CategoryCo... View Issue
  • ‼️ Error: Xdebug has detected a possible infinite loop, and aborted your script with a stack depth of '256'... Ushahidi\Modules\V5\Http\Controllers\CategoryCo... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants