Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use user param to filter notifications and contacts #968

Merged
merged 2 commits into from
Mar 4, 2016

Conversation

jasonmule
Copy link
Contributor

This pull request makes the following changes:

  • Filter contacts and notifications using currently logged in user

Test these changes by:

  • See api.notifications.feature and api.contacts.feature

Fixes #954 .

Ping @ushahidi/platform

Review on Reviewable

$user = $this->getUser();

// Limit search to user's records unless they are admin
if (! $this->isUserAdmin($user)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be removing this. Though maybe we should update it to check a permission as well as isUserAdmin()

rjmackay added a commit that referenced this pull request Mar 4, 2016
Use user param to filter notifications and contacts
@rjmackay rjmackay merged commit d36f44e into develop Mar 4, 2016
@rjmackay rjmackay deleted the 954-duplicate-notifications branch June 29, 2016 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants