Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Profile XSD shows lapse in XSD production from metaschema #251

Closed
wendellpiez opened this issue Oct 11, 2018 · 3 comments
Closed

BUG: Profile XSD shows lapse in XSD production from metaschema #251

wendellpiez opened this issue Oct 11, 2018 · 3 comments
Labels
bug Scope: Content Development of OSCAL content and examples. User Story

Comments

@wendellpiez
Copy link
Contributor

wendellpiez commented Oct 11, 2018

User Story:

Some correct profile instance documents (XML) cannot be validated against the Profile XSD while its model does not permit choice inside select. This lapse is happening because the declaration is not being imported correctly into the profile metaschema (from the catalog metaschema) when the XSD is generated.

Goals:

Correct the schema so that the profile schema matches the catalog schema with regard to set-param and its descendants including select and choice.

Consider renaming choice to value for consistency.

Dependencies:

Either metaschema production must be stable for this to be corrected in a separate branch, or the correction should be declared in scope for another issue related to metaschema development.

Acceptance Criteria

  1. A document that uses set-param, select and choice (or value) must be shown to be valid to the new XSD
  2. Ideally, testing of a pathological data instance against the schema would also validate against similar problems elsewhere
@wendellpiez
Copy link
Contributor Author

Update Nov 28

Current work on the metaschema in branch https://github.com/wendellpiez/OSCAL/tree/feature-metaschema-d2-next will address this issue.

The mechanism for importing definitions from other metaschemas is being overhauled to be more robust.

@david-waltermire david-waltermire added this to the OSCAL 1.0 M1 milestone May 8, 2019
@david-waltermire david-waltermire added bug Scope: Content Development of OSCAL content and examples. labels May 9, 2019
@wendellpiez
Copy link
Contributor Author

This was addressed in work in PR #339 and is now working in master. Issue is closable.

@david-waltermire
Copy link
Contributor

Ok. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Scope: Content Development of OSCAL content and examples. User Story
Projects
None yet
Development

No branches or pull requests

2 participants