Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to metaschema, schemas and samples #339

Merged
merged 2 commits into from
Apr 19, 2019

Conversation

wendellpiez
Copy link
Contributor

@wendellpiez wendellpiez commented Apr 10, 2019

See Issue #327.

Committer Notes

Includes incremental changes to metaschema design including better support for modular metaschemas and new modules for metadata and resources, shared by catalog and profile schemas. Many improvements to metaschema design for usability (thanks @brianrufgsa ).

Experimental metaschemas for the implementation layer are left in place; they may require adjustment.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions] This is a single commit

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them? More documentation on Metaschema in general is called for
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?

Copy link
Contributor

@anweiss anweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only contains metaschema-related changes which is exactly what this PR describes.

Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@david-waltermire david-waltermire merged commit 092e45a into usnistgov:master Apr 19, 2019
wendellpiez added a commit to wendellpiez/OSCAL that referenced this pull request May 3, 2019
Improvements to metaschema, schemas and samples (usnistgov#339)
@wendellpiez wendellpiez deleted the feature-metaschema-d4 branch May 16, 2019 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants