Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make @control-id required for Profile Alter Statements #1111

Merged

Conversation

aj-stein-nist
Copy link
Contributor

@aj-stein-nist aj-stein-nist commented Jan 26, 2022

Committer Notes

Closes #1053.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

Resolves #1053.

Discussed with the team and agreed that this is in fact a bug that
requires a backward-breaking compatibility change to fix.
@aj-stein-nist aj-stein-nist changed the base branch from main to release-1.0 January 26, 2022 20:57
Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@david-waltermire david-waltermire merged commit 2c1fd5f into release-1.0 Jan 26, 2022
@david-waltermire david-waltermire deleted the issue-1053-profile-control-id-required branch February 26, 2022 20:02
iMichaela pushed a commit to iMichaela/OSCAL that referenced this pull request Apr 7, 2022
…#1111)

Resolves usnistgov#1053.

Discussed with the team and agreed that this is in fact a bug that
requires a backward-breaking compatibility change to fix.
Rene2mt pushed a commit to Rene2mt/OSCAL that referenced this pull request May 17, 2022
…#1111)

Resolves usnistgov#1053.

Discussed with the team and agreed that this is in fact a bug that
requires a backward-breaking compatibility change to fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Profile Schema: "control-id" is currently optional
2 participants