Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating core documentation #1157

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Updating core documentation #1157

merged 2 commits into from
Mar 15, 2022

Conversation

david-waltermire
Copy link
Contributor

@david-waltermire david-waltermire commented Feb 26, 2022 •
edited
Loading

Committer Notes

Updating readmes with more current and relevant information.
Adding CODEOWNERS to drive reviews.

All Submissions:

  • Have you selected the correct base branch per Contributing guidance?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

@david-waltermire david-waltermire force-pushed the update-repo-readmes branch 2 times, most recently from 211d2bb to 914ca9a Compare February 26, 2022 23:57
aj-stein-nist
aj-stein-nist previously approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Found a minor pre-existing space issue, but I learned some new things today. :-)

.github/CODEOWNERS Show resolved Hide resolved
.github/PULL_REQUEST_TEMPLATE.md Outdated Show resolved Hide resolved
@david-waltermire @aj-stein-nist
Update .github/PULL_REQUEST_TEMPLATE.md
201be9e 
Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
@aj-stein-nist aj-stein-nist mentioned this pull request Mar 4, 2022
Closed
7 tasks
aj-stein-nist
aj-stein-nist approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion with Dave, the only concern I had was the GitHub warnings on the CODEOWNERS file. Everything else looks good, so we can just move forward and test it.

@david-waltermire david-waltermire merged commit 8d47c75 into usnistgov:main Mar 15, 2022
@david-waltermire david-waltermire deleted the update-repo-readmes branch March 15, 2022 16:00
@aj-stein-nist aj-stein-nist mentioned this pull request Mar 17, 2022
Merged
5 tasks
@david-waltermire david-waltermire added this to the OSCAL 1.0.2 milestone Mar 21, 2022
iMichaela pushed a commit to iMichaela/OSCAL that referenced this pull request Apr 7, 2022
@david-waltermire @aj-stein-nist @iMichaela
Updating core documentation (usnistgov#1157)
707005f 
* Updating readmes with more current and relevant information.
* Adding CODEOWNERS to drive reviews.
* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
Rene2mt pushed a commit to Rene2mt/OSCAL that referenced this pull request May 17, 2022
@david-waltermire @aj-stein-nist @Rene2mt
Updating core documentation (usnistgov#1157)
18f5653 
* Updating readmes with more current and relevant information.
* Adding CODEOWNERS to drive reviews.
* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: Alexander Stein <alexander.stein@nist.gov>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj-stein-nist aj-stein-nist aj-stein-nist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
OSCAL 1.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@david-waltermire @aj-stein-nist