Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize enumerated namespace values to use http prefix consistently #1233

Merged
merged 4 commits into from
May 5, 2022
Merged

Normalize enumerated namespace values to use http prefix consistently #1233

merged 4 commits into from
May 5, 2022

Conversation

david-waltermire
Copy link
Contributor

@david-waltermire david-waltermire commented May 5, 2022 •
edited
Loading

Committer Notes

Enumerated namespace values in the OSCAL models inconsistently use http and https prefixes. This PR normalizes these values to consistently use http.

All Submissions:

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

aj-stein-nist
aj-stein-nist approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@aj-stein-nist aj-stein-nist left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's one way to solve the problem quickly. 🚢

@david-waltermire david-waltermire force-pushed the normalize-namespace-values branch from 4a8f5e1 to fef007d Compare May 5, 2022 15:16
@david-waltermire david-waltermire added this to the OSCAL 1.0.3 milestone May 5, 2022
@david-waltermire david-waltermire merged commit 02418c9 into usnistgov:release-1.0 May 5, 2022
@david-waltermire david-waltermire deleted the normalize-namespace-values branch May 5, 2022 16:40
david-waltermire added a commit that referenced this pull request May 5, 2022
@david-waltermire
Normalize enumerated namespace values to use http prefix consistently (…
1fb37bd 
…#1233)

* Normalized enumerated namespace values to use http prefix consistently; created deprecation entries where needed.
* Updating examples to be consistent with namespace values.
Rene2mt pushed a commit to Rene2mt/OSCAL that referenced this pull request May 17, 2022
@david-waltermire @Rene2mt
Normalize enumerated namespace values to use http prefix consistently (…
fdfcd3a 
…usnistgov#1233)

* Normalized enumerated namespace values to use http prefix consistently; created deprecation entries where needed.
* Updating examples to be consistent with namespace values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj-stein-nist aj-stein-nist aj-stein-nist approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
OSCAL 1.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@david-waltermire @aj-stein-nist