Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Public Meetings Pages for New Slate of Meetings #1614

Conversation

aj-stein-nist
Copy link
Contributor

@aj-stein-nist aj-stein-nist commented Jan 12, 2023

Committer Notes

Closes #1560.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

Changes to Core Features:

  • ~Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@aj-stein-nist aj-stein-nist self-assigned this Jan 12, 2023
@aj-stein-nist aj-stein-nist force-pushed the 1560-update-community-meetings-pages branch from 8633ca0 to b4dd0f7 Compare January 12, 2023 23:32
@aj-stein-nist aj-stein-nist marked this pull request as ready for review January 12, 2023 23:57
@aj-stein-nist
Copy link
Contributor Author

aj-stein-nist commented Jan 13, 2023

OK @david-waltermire-nist @Compton-NIST and @iMichaela, there are still some open questions, but we need to do this sooner rather than later.

  • We need to decide final time for DEFINE (like which day on the month it starts) and if it will be on Thursday, please let me know by COB tomorrow or sooner for this review. @Compton-NIST and @iMichaela I will need feedback from you on this. @david-waltermire-nist, I will need to know which Thursday the OSCAL Engineering Meeting kicks off
  • I need to add ICS files or figure out an alternative calendaring method. I have an idea, but must test and validate. I will spike this quickly tomorrow. If I do not have a solution by COB tomorrow, I will add new ICS files and continue as desired see [RFC] Add a Calendar Feed for NIST OSCAL Events to OSCAL Site? #1408 for details from previous conversation about this. Now appears to be the time. @david-waltermire-nist, I will decide this with you. Defer until later with follow-up research.

Copy link
Contributor

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old model meeting pdfs and pptxs, and meeting mds should be moved to model-engineering-meeting.

Other comments are inline.

docs/content/contribute/define-meeting/_index.md Outdated Show resolved Hide resolved
docs/content/contribute/define-meeting/_index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the date and provide a starting month for the meetings.

@david-waltermire
Copy link
Contributor

OK @david-waltermire-nist @Compton-NIST and @iMichaela, there are still some open questions, but we need to do this sooner rather than later.

@david-waltermire-nist, I will need to know which Thursday the OSCAL Engineering Meeting kicks off

Let's go with Thursday, January 26th @ 10 am EDT/EST.

* [ ]  I need to add ICS files or figure out an alternative calendaring method. I have an idea, but must test and validate. I will spike this quickly tomorrow. If I do not have a solution by COB tomorrow, I will add new ICS files and continue as desired see [[RFC] Add a Calendar Feed for NIST OSCAL Events to OSCAL Site? #1408](https://github.com/usnistgov/OSCAL/issues/1408) for details from previous conversation about this. Now appears to be the time. @david-waltermire-nist, I will decide this with you.

@aj-stein-nist Happy to work this out with you tomorrow (1/13/2023).

@aj-stein-nist
Copy link
Contributor Author

Please update the date and provide a starting month for the meetings.

@iMichaela what will the starting day of week and date before the DEFINE meeting, it was not clear from email if Thursday or Friday if chosen. Then, what specific day of the month. Once that is ready, we can finish this up.

@Compton-US
Copy link
Contributor

Compton-US commented Jan 13, 2023

@aj-stein-nist I think this comment covered start time for DEFINE:
"starting in February 2023, on the third Th of each month at 11:00AM ET". (which should be Feb 16)

#1614 (comment)

@aj-stein-nist
Copy link
Contributor Author

@aj-stein-nist I think this comment covered start time for DEFINE: "starting in February 2023, on the third Th of each month at 11:00AM ET". (which should be Feb 16)

#1614 (comment)

Wow, what is embarrassing is that I should remember that comment, it was only a scroll away. Thanks for that! I will adjust it shortly.

@aj-stein-nist aj-stein-nist force-pushed the 1560-update-community-meetings-pages branch from fa68772 to 7d70504 Compare January 14, 2023 05:58
@aj-stein-nist
Copy link
Contributor Author

The old model meeting pdfs and pptxs, and meeting mds should be moved to model-engineering-meeting.

Other comments are inline.

Just to confirm Dave, I did a git mv so the old dirs were deleted and all slide decks and meetings not were moved to their directory names. I am marking this ready for review, @david-waltermire-nist and @iMichaela.

@aj-stein-nist aj-stein-nist requested review from david-waltermire and iMichaela and removed request for Compton-US January 14, 2023 06:00
@iMichaela
Copy link
Contributor

Please update the date and provide a starting month for the meetings.

@iMichaela what will the starting day of week and date before the DEFINE meeting, it was not clear from email if Thursday or Friday if chosen. Then, what specific day of the month. Once that is ready, we can finish this up.

The OSCAL DEFINE meetings will be held on the third Thursday of the week at 11:00AM, starting with February 2023.

The mini workshops will follow as earlier announced: the third Wednesday of the month, at 11:00 AM EST. That page will be updated with another PR, as soon as I am receiving the confirmation of availability to present from this month's presenter which has/had medical issues.

Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have one suggestion (please see below)

Update pages with invite info.

Co-authored-by: David Waltermire <david.waltermire@nist.gov>
@aj-stein-nist aj-stein-nist force-pushed the 1560-update-community-meetings-pages branch from 7d70504 to 63762f9 Compare January 17, 2023 18:51
@aj-stein-nist
Copy link
Contributor Author

I also corrected the February 23 to February 16th typo when doing a final spot check, can I get a final approval review @david-waltermire-nist?

iMichaela
iMichaela previously approved these changes Jan 18, 2023
Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did provide one more comment, that might clarify a little more when the meetings will take place, but please feel free to merge, once you make the decision to address it or ignore it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Community Meetings Pages
4 participants