-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added artifact usage + corrected dead links #1865
Added artifact usage + corrected dead links #1865
Conversation
@aj-stein-nist should this PR target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a lot of simple changes, though I'm not sure if link validator can validate ./ and ../../../ paths. Can it?
I assume we will make all changes and prep for a release (so |
Pull down the branch, go into the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait hold up, I am glad Dmitry asked there is some issue with how linkcheck is run locally and it fails, is it the same in CI/CD?
Yeah I'm getting a traceback:
But this doesn't happen in CI? Weird |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I apologize. I had not properly pulled down the correct updated branch locally as I was replying to @JustKuzya. 🤦 This is good and valid, I go back to approving (it's a little slower locally than I recalled).
I only get that when link check fails, but on clean branches I don't get the stack trace, weird to me too. I guess we can review and reconsider the issue, reassessing markdown-link-checker if we'd like. |
Committer Notes
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)
Changes to Core Features: