[WIP] Profiler error handling #1940
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.6.0 to 4.0.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@f43a0e5...3df4ab1) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.0.0 to 4.1.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@3df4ab1...8ade135) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [build/metaschema-xslt](https://github.com/usnistgov/metaschema-xslt) from `034e92b` to `bd4359a`. - [Commits](usnistgov/metaschema-xslt@034e92b...bd4359a) --- updated-dependencies: - dependency-name: build/metaschema-xslt dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Based on the content of the catalog whose controls are being imported, the prop names should be "label" instead of "place" and the a1 statement paragraph should include <insert>. Also, remove a debugging message.
Unselected parent could have multiple children that are selected, so data type of template must accommodate multiple elements.
* Separate before/after from starting/ending in modify phase * Enhance message-handler.xsl for pipeline usage and testability * Adapt XSLT to message handler returning PI * Enable saving intermediate XML files for debugging purposes * Add sample document for nonfatal errors/warnings Bug fixes: * Enable param to have insertions before/after AND have param set * Fix merge phase bug where descendant controls weren't being flattened
Now that opr:oscal-version returns item()+ to accommodate error PI, output of $source should use xsl:sequence instead of xsl:value-of to retain string data type. XSpec tests for this function should expect PI, not error map.
aj-stein-nist
force-pushed
the
profiler-error-handling
branch
from
5d3b9b3
to
5ae62a4
Compare
The XSLT changes in this pull request should already fix #1859. This commit adds a relevant test scenario as evidence.
aj-stein-nist
force-pushed
the
profiler-error-handling
branch
from
5ae62a4
to
14af5b4
Compare
aj-stein-nist
force-pushed
the
develop
branch
from
0825b9f
to
651deef
Compare
|
Close this now that I heard back from @galtm in #1549 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Shadowing #1549 for testing until that PR can be reopened for final review and merger per #1549 (comment).
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.
(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)
Changes to Core Features: