Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flatten codeowners #1962

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Flatten codeowners #1962

merged 2 commits into from
Nov 29, 2023

Conversation

nikitawootten-nist
Copy link
Contributor

@nikitawootten-nist nikitawootten-nist commented Nov 21, 2023

Committer Notes

Codeowners file now defaults to @usnistgov/itl-oscal-maintainers.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikitawootten-nist
-- 1) it turns out that @Compton-NIST is not a member of the usnitgov/itl-oscal, and I cannot fix it because @aj-stein-nist is the maintainer. We should also review all the other usnistgov/its-oscal-* teams and update them.
-- 2) maybe some (critical) directories should remain protected and only its-oscal-admins should own the code in those directories currently owned by its-oscal-maintainers which does not even exist among usnistgov teams.

@aj-stein-nist
Copy link
Contributor

@nikitawootten-nist -- 1) it turns out that @Compton-NIST is not a member of the usnitgov/itl-oscal, and I cannot fix it because @aj-stein-nist is the maintainer. We should also review all the other usnistgov/its-oscal-* teams and update them.

I just saw this update. You @iMichaela were added to the maintainer list and I removed myself.

-- 2) maybe some (critical) directories should remain protected and only its-oscal-admins should own the code in those directories currently owned by its-oscal-maintainers which does not even exist among usnistgov teams.

You have to be logged in for itl-oscal-maintainers as it is a private group, or otherwise you will not see or you are logged in and you are not a member. For you that problem should now be solved. Let me know if you need anything else.

@iMichaela
Copy link
Contributor

You have to be logged in for itl-oscal-maintainers as it is a private group, or otherwise you will not see or you are logged in and you are not a member. For you that problem should now be solved. Let me know if you need anything else.

Thank you, @aj-stein-nist , for updating the roles. I'll work with @nikitawootten-nist on the -- 1) , second part.

Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The system reports an error because 2 groups (out of three used) are not public. The groups exist and have access to the repo. The fact that the 2 groups are not public might not be a problem (we operated this way before).

@Compton-US Compton-US merged commit fe39318 into develop Nov 29, 2023
1 check passed
Compton-US pushed a commit that referenced this pull request Dec 6, 2023
* Flatten codeowners

* Update CODEOWNERS with feedback from the team
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants