Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated prototype shared-responsibility model. #2000

Conversation

nikitawootten-nist
Copy link
Contributor

Committer Notes

This PR supersedes #1999. The new prototype-shared-responsibility-model-rebased on usnistgov/OSCAL contains only metaschema updates from the previous prototype rebased against main. This PR contains work by @iMichaela making further updates to the model in preparation for an RC1 after community review.

The prototype shared-responsibility model was updated and the documentation was reviewed. This version of the model is ready for review and integration into the OSCAL v1.2.0 release candidate. The prototype was locally tested with the latest metaschema-xslt/document-display-deprecation

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@nikitawootten-nist
Copy link
Contributor Author

@david-waltermire continuing the conversation, here is a clean history. The prototype branch has also been rebased and cherry picked against develop.

Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikitawootten-nist - The schemas and resolved metaschemas are generated correctly, without errors. No validation errors exist so the commits fixing them were all incorporated. Building locally the reference site is not working though from the new prototype branch due to name convention of the branch not being respected. I could not check the documentation locally.

Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikitawootten-nist - I found that the oscal_control-common_metaschema.xml file did not have the schema-version updated since 1.0.4 release. I am not aware of any reason why. Are you? All other files were updated.

@iMichaela iMichaela mentioned this pull request Mar 30, 2024
9 tasks
@iMichaela iMichaela merged commit 28d1501 into usnistgov:prototype-shared-responsibility-model-rebased Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants