Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node version for build: v16 -> v20 #2034

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

d10n
Copy link

@d10n d10n commented Aug 15, 2024

I'm hoping that this will resolve the error in #2018, which fails with:
ReferenceError: ReadableStream is not defined and

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: 'whatwg-mimetype@4.0.0',
npm WARN EBADENGINE   required: { node: '>=18' },
npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
npm WARN EBADENGINE }

Will test in the pipeline


The pipeline failed, so before we can see if the unsupported engine issue above is resolved, the new pipeline error needs to be fixed.
After investigating a little further, it seems like there might be an issue when checking multiple files for broken links at once, so the 2nd commit checks 1 file at a time as a workaround.

Committer Notes

{Please provide a brief description of what this PR accomplishes. Be sure to reference any issues addressed. If the PR is a work-in-progress submitted for early review, please include [WIP] at the beginning of the title or mark the PR as DRAFT.}

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@d10n d10n requested a review from a team as a code owner August 15, 2024 17:44
markdown-link-check seems to have intermittent errors when checking
multiple files at a time. This change might be a workaround.
Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes are good. Tested locally.

@iMichaela iMichaela merged commit fe64bdd into usnistgov:develop Aug 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants