Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed incorrect enforcement of asset-id property at implemented-com… #2064

Merged

Conversation

brian-ruf
Copy link
Contributor

Removes a constraint that incorrectly required an asset-id property at /system-security-plan/system-implementation/inventory-item/implemented-component as discussed in issue #2043

Committer Notes

{Please provide a brief description of what this PR accomplishes. Be sure to reference any issues addressed. If the PR is a work-in-progress submitted for early review, please include [WIP] at the beginning of the title or mark the PR as DRAFT.}

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

(For reviewers: The wiki has guidance on code review and overall issue review for completeness.)

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all OSCAL website and readme documentation affected by the changes you made? Changes to the OSCAL website can be made in the docs/content directory of your branch.

@brian-ruf brian-ruf requested a review from a team as a code owner November 9, 2024 01:40
@iMichaela iMichaela added the Waiting for Action Waiting for an external action to be taken label Nov 14, 2024
@iMichaela iMichaela changed the base branch from main to develop November 15, 2024 12:58
Copy link
Contributor

@iMichaela iMichaela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of the constraint makes sense per discussion on #2043

@iMichaela iMichaela merged commit a71fe53 into usnistgov:develop Nov 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Waiting for Action Waiting for an external action to be taken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants