Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent quotations in serialized XML declaration #14

Closed
Tracked by #1282
david-waltermire opened this issue May 10, 2022 · 0 comments · Fixed by usnistgov/metaschema-java#53
Closed
Tracked by #1282
Assignees
Labels
bug Something isn't working

Comments

@david-waltermire
Copy link
Collaborator

Describe the bug

Serialized output XML declaration includes inconsistent quotations. i.e "value" vs 'value'

Who is the bug affecting?

Users that serialize into XML.

What is affected by this bug?

The serialized XML output is valid but uses inconsistent quotation within the file and is not consistent with the input file.

When does this occur?

When serializing a OSCAL document node into XML.

How do we replicate the issue?

  1. Modify OscalBindingContextTest.testLoadCatalogXml(@TempDir Path tempDir) to no longer delete the output.
  2. Execute test.
  3. Review test output file.

Output

<?xml version='1.0' encoding='UTF-8'?>
<catalog xmlns="http://csrc.nist.gov/ns/oscal/1.0" uuid="4cd70b73-a0be-4bf5-9cc6-6535dd251939">
  <metadata>
...

Expected behavior (i.e. solution)

<?xml version="1.0" encoding="UTF-8"?>
<catalog xmlns="http://csrc.nist.gov/ns/oscal/1.0" uuid="4cd70b73-a0be-4bf5-9cc6-6535dd251939">
  <metadata>
...

Other Comments

None

@david-waltermire david-waltermire added the bug Something isn't working label May 10, 2022
@david-waltermire david-waltermire self-assigned this May 10, 2022
@david-waltermire david-waltermire added this to the v1.0.3 Release milestone May 10, 2022
david-waltermire added a commit to david-waltermire/metaschema-java-old that referenced this issue Jun 21, 2022
david-waltermire added a commit to usnistgov/metaschema-java that referenced this issue Jun 21, 2022
david-waltermire added a commit to usnistgov/metaschema-java that referenced this issue Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant