Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend AbstractOscalInstance for all document types #129

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

laurelmay
Copy link
Contributor

@laurelmay laurelmay commented Apr 4, 2023

Committer Notes

Currently only Catalog and Profile extend AbstractOscalInstance
which means that it's currently hard to be generic over all document
types (<T extends IOscalInstance>).

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website and readme documentation affected by the changes you made?

Currently only `Catalog` and `Profile` extend `AbstractOscalInstance`
which means that it's currently hard to be generic over all document
types (`<T extends IOscalInstance>`).
@laurelmay laurelmay changed the base branch from main to develop April 4, 2023 15:53
@aj-stein-nist aj-stein-nist self-requested a review April 7, 2023 12:42
@aj-stein-nist aj-stein-nist merged commit 4e6551c into usnistgov:develop Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants