Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax Map Improvements #105

Closed
3 tasks
brian-ruf opened this issue Dec 17, 2020 · 1 comment · Fixed by #127
Closed
3 tasks

Syntax Map Improvements #105

brian-ruf opened this issue Dec 17, 2020 · 1 comment · Fixed by #127
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@brian-ruf
Copy link

User Story:

s an OSCAL implementer, when reviewing the OSCAL syntax maps it would be helpful to use background and border shading similar to what was used in the original version of the generated maps.

In the original version, when hovering over an assembly the box would highlight in a very visible and obvious way. With the new document map generation, the highlights are too subtle and easy to miss.

Goals:

  • Improve the visual clues when hovering over an assembly to better match the hover behavior and color selection in the original document maps.

Dependencies:

None.

Acceptance Criteria

  • All website and readme documentation affected by the changes in this issue have been updated. Changes to the website can be made in the docs/content directory of your branch.
  • A Pull Request (PR) is submitted that fully addresses the goals of this User Story. This issue is referenced in the PR.
  • The CI-CD build process runs without any reported errors on the PR. This can be confirmed by reviewing that all checks have passed in the PR.
@wendellpiez
Copy link
Collaborator

On the models maps the border (on an element or object) now goes darker on hover.

Unfortunately CSS doesn't let us do much more than this. Setting background color to respond to hover results only in the entire containing structure (entire tree) receiving the new background - i.e. background changes not only on the innermost hovered element, but on all of them, because the containing element is also hovered when the contained element is (at any level). The logic we apparently need ('shift the background when hovered but not when a descendant is hovered') is not expressible in CSS (is it?).

Ideas for further enhancement are certainly welcome!

@david-waltermire david-waltermire linked a pull request Mar 30, 2021 that will close this issue
8 tasks
wendellpiez added a commit to wendellpiez/OSCAL that referenced this issue Mar 30, 2021
david-waltermire pushed a commit to usnistgov/OSCAL that referenced this issue Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants