Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing XML- and JSON -conversion logic for metaschema constructs #36

Merged

Conversation

wendellpiez
Copy link
Collaborator

OSCAL has usnistgov/OSCAL#609 with model changes (renaming set-param to set-parameter). Integrating new testing has also revealed an error in data conversions, exposed in the sample SSP.

This PR introduces changes to the metaschema implementation to support this repair.

Committer Notes

A successful build will show data conversions from XML samples into JSON, and vice-versa, and round-tripped back with no data loss, as shown in the build scripting.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@david-waltermire david-waltermire marked this pull request as ready for review February 5, 2020 22:37
@david-waltermire david-waltermire merged commit b234d5a into usnistgov:master Feb 5, 2020
@wendellpiez wendellpiez deleted the oscal-issue609-metaschema branch November 10, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants