-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow proceeding zeros in factional seconds #379
Allow proceeding zeros in factional seconds #379
Conversation
e8c1f3f
to
ceb2b71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am good with the change, I would recommend adding the example 2019-09-28T23:00:00.0Z
or one with more trailing zeros so we can copy-paste the examples in the datatypes page so I can use things like regex101.com to make testing quicker.
We also want to optionally consider change the 60 second examples because those don't validate (such at 60
in 2019-12-31T23:59:60Z
because of how seconds work), but that is minor. Otherwise, this looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wendellpiez and I generated the OSCAL schemas and have confirmed that this fixes usnistgov/OSCAL#1774. Looks good to us!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We reviewed and validated the regex (and learned many things about the containers/distro while doing so) thanks for the work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add an example to the following schema validation test: https://github.com/usnistgov/metaschema/blob/main/test-suite/schema-generation/datatypes/datatypes-datetime_test_valid_PASS.json
Committer Notes
Allow proceeding zeros in factional seconds.
This addresses the issue identified in usnistgov/liboscal-java#141 and usnistgov/OSCAL#1774.
All Submissions:
Changes to Core Features: