Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow proceeding zeros in factional seconds #379

Conversation

david-waltermire
Copy link
Collaborator

@david-waltermire david-waltermire commented Jun 8, 2023

Committer Notes

Allow proceeding zeros in factional seconds.

This addresses the issue identified in usnistgov/liboscal-java#141 and usnistgov/OSCAL#1774.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@david-waltermire david-waltermire force-pushed the issue-liboscal-141-franctional-seconds-proceeding-zeros branch from e8c1f3f to ceb2b71 Compare June 8, 2023 05:58
@david-waltermire david-waltermire changed the title Allow proceeding zeros in factional sections Allow proceeding zeros in factional seconds Jun 8, 2023
aj-stein-nist
aj-stein-nist previously approved these changes Jun 8, 2023
Copy link
Collaborator

@aj-stein-nist aj-stein-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good with the change, I would recommend adding the example 2019-09-28T23:00:00.0Z or one with more trailing zeros so we can copy-paste the examples in the datatypes page so I can use things like regex101.com to make testing quicker.

We also want to optionally consider change the 60 second examples because those don't validate (such at 60 in 2019-12-31T23:59:60Z because of how seconds work), but that is minor. Otherwise, this looks good!

Copy link
Contributor

@nikitawootten-nist nikitawootten-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wendellpiez and I generated the OSCAL schemas and have confirmed that this fixes usnistgov/OSCAL#1774. Looks good to us!

Copy link
Collaborator

@wendellpiez wendellpiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We reviewed and validated the regex (and learned many things about the containers/distro while doing so) thanks for the work

@david-waltermire david-waltermire added this to the Metaschema 0.9.0 milestone Jun 9, 2023
Copy link
Contributor

@nikitawootten-nist nikitawootten-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-waltermire david-waltermire merged commit f069aa8 into usnistgov:develop Jun 26, 2023
@david-waltermire david-waltermire deleted the issue-liboscal-141-franctional-seconds-proceeding-zeros branch June 26, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants