Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair JSON array conversion bug #41

Conversation

wendellpiez
Copy link
Collaborator

Committer Notes

Small adjustment in XML-to-JSON converter generator repairs a bug exposed in testing when in-json is set to 'ARRAY'.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@wendellpiez wendellpiez changed the title Repair json array conversion feb2020 Repair JSON array conversion bug Feb 10, 2020
Copy link
Collaborator

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for updating the paths in the XML processing instructions.

@david-waltermire david-waltermire merged commit d10c30d into usnistgov:master Feb 10, 2020
wendellpiez added a commit to wendellpiez/metaschema that referenced this pull request May 15, 2020
… XML->JSON path mapping. More testing required.
wendellpiez added a commit to wendellpiez/metaschema that referenced this pull request Jun 11, 2020
… XML->JSON path mapping. More testing required.
david-waltermire pushed a commit that referenced this pull request Sep 17, 2020
@wendellpiez wendellpiez deleted the repair-json-array-conversion-feb2020 branch November 10, 2020 19:11
wendellpiez added a commit to wendellpiez/metaschema that referenced this pull request Nov 10, 2020
… XML->JSON path mapping. More testing required.
david-waltermire pushed a commit that referenced this pull request Nov 13, 2020
david-waltermire pushed a commit that referenced this pull request Dec 21, 2020
wandmagic pushed a commit to wandmagic/metaschema that referenced this pull request Nov 24, 2024
…-schema-generation-tests-20241026

Unit Test Cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants