Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oscal issue678 milestone3 enhancements #54

Conversation

wendellpiez
Copy link
Collaborator

@wendellpiez wendellpiez commented May 28, 2020

Committer Notes

This PR addresses functionality gaps in Metaschema for OSCAL Milestone 3 as described in usnistgov/OSCAL#678.

The second gap identified had already been addressed by PR #13 and will also be in next-gen Metaschema.

The first requirement is support for an actual (lexical) JSON data type for a "uuid". Note: currently, we do not validate the uniqueness of UUID values or indeed (always) ID values in the generated schemas. This support is so far only for the lexical form of a string (flag or field value) expected to be a UUID.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Do all automated CI/CD checks pass?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you included examples of how to use your new feature(s)?
  • Have you updated all website](https://pages.nist.gov/metaschema) and readme documentation affected by the changes you made? Changes to the website can be made in the website/content directory of your branch.

@wendellpiez wendellpiez marked this pull request as ready for review May 29, 2020 15:07
Copy link
Collaborator

@david-waltermire david-waltermire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@david-waltermire david-waltermire merged commit 22de1d0 into usnistgov:master May 29, 2020
@wendellpiez wendellpiez deleted the oscal-issue678-Milestone3-enhancements branch November 10, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants