Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests with shell commands #178

Closed
1 task done
aj-stein-nist opened this issue Aug 14, 2023 · 2 comments · Fixed by #211
Closed
1 task done

Add integration tests with shell commands #178

aj-stein-nist opened this issue Aug 14, 2023 · 2 comments · Fixed by #211
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@aj-stein-nist
Copy link
Collaborator

aj-stein-nist commented Aug 14, 2023

User Story:

Evaluate methods of running the final command line utility with a series of tests with data instances and all the formats to find missing gaps and edges in pre-release process.

Goals:

{A clear and concise description of what you want to happen. This should be outcome focused. Include concise description of any alternative solutions or features you've considered. Feel free to include screenshots or examples about the feature request here.}

Dependencies:

{Describe any previous issues or related work that must be completed to start or complete this issue.}

Acceptance Criteria

  • All website and readme documentation affected by the changes in this issue have been updated.
  • A Pull Request (PR) is submitted that fully addresses the goals of this User Story. This issue is referenced in the PR.
  • The CI-CD build process runs without any reported errors on the PR. This can be confirmed by reviewing that all checks have passed in the PR.
@aj-stein-nist aj-stein-nist added the enhancement New feature or request label Aug 14, 2023
@aj-stein-nist aj-stein-nist added this to the Future milestone Aug 15, 2023
@aj-stein-nist aj-stein-nist moved this from Todo to Needs Triage in NIST OSCAL Work Board Sep 21, 2023
@aj-stein-nist aj-stein-nist moved this from Needs Triage to Todo in NIST OSCAL Work Board Sep 28, 2023
@aj-stein-nist aj-stein-nist modified the milestones: Future, Next Sep 28, 2023
@aj-stein-nist
Copy link
Collaborator Author

Given certain scheduling constraints, I feel it is important that we release 1.0.2 and tackle this in the next release in October or November (based on organizational constraints easily findable in your favorite new source). I have discussed with @david-waltermire-nist and will evaluate how to do shell-based CLI testing with the Maven failsafe plugin in the next iteration.

Thanks for bringing this back to my attention @ajnelson-nist.

@aj-stein-nist aj-stein-nist moved this from Todo to In Progress in NIST OSCAL Work Board Oct 19, 2023
aj-stein-nist added a commit that referenced this issue Oct 19, 2023
aj-stein-nist added a commit that referenced this issue Oct 24, 2023
aj-stein-nist added a commit that referenced this issue Oct 26, 2023
aj-stein-nist added a commit that referenced this issue Oct 26, 2023
aj-stein-nist added a commit that referenced this issue Oct 26, 2023
@aj-stein-nist aj-stein-nist linked a pull request Oct 26, 2023 that will close this issue
7 tasks
@aj-stein-nist aj-stein-nist moved this from In Progress to Under Review in NIST OSCAL Work Board Oct 26, 2023
@aj-stein-nist aj-stein-nist self-assigned this Oct 26, 2023
aj-stein-nist added a commit that referenced this issue Oct 27, 2023
Per discussion with Dave and re-reviewing the tutorial section on steps
for installation I had missed, add that dependency to the POM for #178.

Also, per his recommendation, add it to the test scope and do not set an
explicit version number because the core JUnit5 version is handled by the
support POM for oss-maven project shared across the different Java
projects.
aj-stein-nist added a commit that referenced this issue Nov 30, 2023
* Add integration tests for #178.

* Use only paths, not URLs

Adjust method to load files PR per @david-waltermire-nist's rec.

* Parameterize tests and fix bad profiles for #178.

* Add junit-jupiter-params to POM test scope

Per discussion with Dave and re-reviewing the tutorial section on steps
for installation I had missed, add that dependency to the POM for #178.

Also, per his recommendation, add it to the test scope and do not set an
explicit version number because the core JUnit5 version is handled by the
support POM for oss-maven project shared across the different Java
projects.
@aj-stein-nist aj-stein-nist moved this from Under Review to Done in NIST OSCAL Work Board Jan 31, 2024
@aj-stein-nist
Copy link
Collaborator Author

These tests have been used in develop branch for a while and will be run as part of the upcoming patch release.

@aj-stein-nist aj-stein-nist modified the milestones: Next, Ready Now, v1.0.3 Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant