Merge remote-tracking branch 'USTC/staging' into 10293-design-debt

.circleci/config.yml

@@ -2,7 +2,7 @@ version: 2.1
 orbs:
   git-shallow-clone: guitarrapc/git-shallow-clone@2.8.0
 
-efcms-docker-image: &efcms-docker-image $AWS_ACCOUNT_ID.dkr.ecr.us-east-1.amazonaws.com/ef-cms-us-east-1:4.3.21
+efcms-docker-image: &efcms-docker-image $AWS_ACCOUNT_ID.dkr.ecr.us-east-1.amazonaws.com/ef-cms-us-east-1:4.3.21.1
 
 parameters:
   run_build_and_deploy:

Dockerfile

@@ -28,7 +28,6 @@ RUN apt-get install -y \
   jq \
   graphicsmagick \
   ghostscript \
-  chromium \
   openssh-client \
   postgresql-client \
   sudo

scripts/jest-scripts.config.ts

@@ -39,6 +39,7 @@ const config: Config = {
     '!reports/**',
     '!run-once-scripts/**',
     '!set-maintenance-mode-locally.ts',
+    '!template.ts',
     '!upload-practitioner-application-packages.ts',
     '!user/**',
     '!postgres/**',

scripts/reports/reportUtils.md

@@ -0,0 +1,73 @@
+## Argument Parser for Shell Scripts Written in TypeScript
+
+The argument parser is a wrapper of the node:utils `parseArgs` method that aims to standardize how we write shell scripts in TypeScript and centralize text transformation of parsed arguments.
+
+### How to Use the Argument Parser in a Shell Script
+
+Let's say you want the `$1` (first positional) argument to be required and you want to optionally support two additional arguments. Now you can define a `ScriptConfig` object at the top of your script:
+
+```typescript
+const scriptConfig: ScriptConfig = {
+  description: 'some-script.ts - works wonders',
+  parameters: {
+    eventCode: {
+      position: 0,
+      required: true,
+      type: 'string',
+    },
+    fiscal: {
+      default: false,
+      short: 'f',
+      type: 'boolean',
+    },
+    year: {
+      default: '2024',
+      short: 'y',
+      transform: 'number',
+      type: 'string',
+    },
+  },
+};
+```
+
+And then elsewhere in the script you can get the values from the argument parser thusly:
+
+```typescript
+const { eventCode, fiscal, verbose, year } = parseArguments(scriptConfig);
+```
+
+### In Action
+
+Given the configuration above, say you call your script like so:
+
+```bash
+npx ts-node --transpile-only scripts/some-script.ts NOA -f
+```
+
+The argument parser will return the following:
+
+```typescript
+{
+  eventCode: 'NOA',
+  fiscal: true,
+  year: 2024,
+};
+```
+
+### Self-Documenting
+
+All scripts that utilize the argument parser will get a `--help` flag that, when provided, will output usage information automatically generated from the `ScriptConfig` configuration object.
+
+Again, given the configuration above, say you call your script like so:
+
+```bash
+npx ts-node --transpile-only scripts/some-script.ts --help
+```
+
+The argument parser will print the following:
+
+```
+some-script.ts - works wonders
+
+Usage: some-script.ts <eventCode> [ -f -y <year> ]
+```