10432: Performance Measurement - TO TEST #5254
Conversation
…quence takes to run; Add a minimum amount of time to console log the results;
…s and store in an array in props;
…ster client in application context;
…ion for sequences.
…list of sequence to log performance;
| .saveSystemPerformanceData.mockImplementation(() => {}); | ||
| }); | ||
|
|
||
| it('should call persistence method with correct data', async () => { |
There was a problem hiding this comment.
Perhaps it('should not allow unauthorized call to log data')
| ).should('be.visible'); | ||
|
|
||
| retry(() => { | ||
| cy.reload(true); |
There was a problem hiding this comment.
Why the reload? (Just making sure I understand!)
| @@ -46,6 +46,7 @@ IRS_CLIENT_ID=$(aws cognito-idp list-user-pool-clients \ | |||
| echo "DAWSON_ENV='${ENV}'" | |||
| echo "DYNAMODB_TABLE_NAME='${SOURCE_TABLE}'" | |||
| echo "ELASTICSEARCH_ENDPOINT='${ELASTICSEARCH_ENDPOINT}'" | |||
| echo "ELASTICSEARCH_INFO_ENDPOINT='${ELASTICSEARCH_INFO_ENDPOINT}'" | |||
There was a problem hiding this comment.
Nitpick, and probably not worth doing if it involves changing infrastructure, but I wonder if we should give this a clearer name? Info can mean just about anything.
| * logging | ||
| */ | ||
| { | ||
| app.post( |
There was a problem hiding this comment.
Could this contribute to high server load if we end up logging a lot?
| sequences: presenterSequences, | ||
| sequences: Object.entries(presenterSequences).reduce( | ||
| (acc, [sequenceName, sequence]) => { | ||
| const SYSTEM_PERFORMANCE_BLACKLIST: string[] = [ |
There was a problem hiding this comment.
This is super cool! I left a few comments. I would want to understand things a little more clearly before merging to a non-test environment (mostly around server load implications and making sure nested sequences are giving accurate data EDIT: Nevermind! I thought we might be logging something wrong, but it turns out the logging caught something that was wrong!), but I think it's good to test.
This PR might not get merged.
It is working but using CloudWatch Metrics will be too expensive.