10472 story #5545
Merged
10472 story #5545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayFlexy
force-pushed
the
10472-story
branch
4 times, most recently
from
8d45112 to
a66724b
Compare
10472: open pdf previews in new tab wip wip, working irspractioner when opening pdf to new tab wip, add functioning tab sequence rm log statement rm log statements more cleanup rm docstring add check for reader add test and some wip add test for loadPDFForTabAction add void return for promise, explicit readerResult check fix type errors rm globals ignore problematic type checks oops rm modal checks
10472: open pdf previews in new tab wip wip, working irspractioner when opening pdf to new tab wip, add functioning tab sequence rm log statement rm log statements more cleanup rm docstring add check for reader add test and some wip add test for loadPDFForTabAction add void return for promise, explicit readerResult check fix type errors rm globals ignore problematic type checks oops rm modal checks rm from branch add fix for docker compose invocation creates compatibility for docker compose or docker-compose 10472: rm openCaseDocumentDownloadUrl 10472: remove unused code 10472: rm remaining loadPdf code 10472: rm call to removed sequence
web-client/src/presenter/actions/PDFPreviewTab/loadPdfForTabAction.ts
Outdated
Show resolved
Hide resolved
cruzjone-flexion
approved these changes
Dec 20, 2024
cruzjone-flexion
approved these changes
Dec 20, 2024
jimlerza
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Ticket: 10472 - Open PDF in new tab