10489: Status Order Report Enhancements #5600
Conversation
…ventCode to OJR when stricken from trial and jurisdiction is retained;
…her than unused signedByUserId; updated cypress integration test to check for chambers user edge case
| judgeFullName: 'John O. Colvin', | ||
| name: 'Colvin', | ||
| userId: '4497d22-0874-4c5e-ac98-a843d1472baf', |
There was a problem hiding this comment.
Here and below, can we get this data from the judgeColvin user in mockUsers.ts?
| documentMetadata.eventCode = 'OJR'; | ||
| } | ||
|
|
||
| if (['O', 'NOT', 'OJR'].includes(documentMetadata.eventCode)) { |
There was a problem hiding this comment.
Would it be worth pulling these event codes out into a self-documenting constant like eventCodesThatAllowFreeText? (There is probably a better name, but you get the idea!)
| draftOrderState: {}, | ||
| dueDate: '2024-11-05', | ||
| eventCode: 'O', | ||
| orderType: 'statusReport', |
There was a problem hiding this comment.
Can we use constants when possible in this file? E.g., here: STATUS_REPORT_ORDER_OPTIONS.orderTypeOptions.statusReport
There was a problem hiding this comment.
Anywhere we have 'statusReport', 'statusReportStipulatedDecision', 'retained', or 'restoredToGeneralDocket', we should be able to use the STATUS_REPORT_ORDER_OPTIONS object.
| cy.get('#tab-drafts').click(); | ||
| getLastDraftOrderElementFromDrafts().click(); | ||
| cy.get('[data-testid="add-court-issued-docket-entry-button"]').click(); | ||
| cy.get('.select-react-element__control').should('have.text', 'Order'); |
There was a problem hiding this comment.
Let's try avoiding third-party library selectors. I think we can just do #document-type here.
There was a problem hiding this comment.
Same thing anyplace we use this selector below.
There was a problem hiding this comment.
I left a few comments upon which my approval is contingent, but generally looks good! Thanks @nechama-krigsman and @btejha!
flexion#10489