Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10565 bug #5614

Merged
merged 5 commits into from
Dec 3, 2024
Merged

10565 bug #5614

merged 5 commits into from
Dec 3, 2024

Conversation

Mwindo
Copy link
Contributor

@Mwindo Mwindo commented Dec 2, 2024

See #5613

@Mwindo Mwindo marked this pull request as ready for review December 3, 2024 13:57
Comment on lines +93 to +104
return filteredCases.map(filteredCase => {
return {
caseCaption: filteredCase.caseCaption,
docketNumber: filteredCase.docketNumber,
docketNumberWithSuffix: filteredCase.docketNumberWithSuffix,
petitionerNames: filteredCase.petitioners?.map(p => p.name),
petitionerStateNames: filteredCase.petitioners?.map(
p => US_STATES[p.state] || p.state,
),
receivedAt: filteredCase.receivedAt,
};
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Total personal preference and absolutely not necessary to change, but I like using shorthand where possible.

This:

return someArray.map(m => {
  return {
    foo: 'bar'
  };
});

can be shortened by wrapping the return object in parens:

return someArray.map(m => ({
  foo: 'bar'
}));

@jimlerza jimlerza merged commit c772695 into ustaxcourt:staging Dec 3, 2024
88 checks passed
@jimlerza jimlerza deleted the 10565-bug branch December 3, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants