Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10549 design debt intermediate branch to test 1733176098 #5615

Conversation

btejha
Copy link
Contributor

@btejha btejha commented Dec 2, 2024

No description provided.

Comment on lines +171 to +174
<CaseLink
className="no-wrap-text"
formattedCase={formattedCaseDetail}
>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing locally, it seems like the following works:

<CaseLink
  className="mobile-text-wrap"
  formattedCase={formattedCaseDetail}
>

I could be missing something, however. If the above does work, I think we can avoid making a new CSS class and just use the existing one. (In fact, if the above doesn't work, I think we can still avoid making a new CSS class. But let's worry about that only if it doesn't work!)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And if we don't want the docket-number to wrap, we can do:

<CaseLink
  className="mobile-text-wrap"
  formattedCase={formattedCaseDetail}
>
  Docket Number:{' '}
  <span className="no-wrap">
    {formattedCaseDetail.docketNumberWithSuffix}
  </span>
</CaseLink>

Copy link
Contributor

@Mwindo Mwindo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, I think we can use existing CSS classes to get the behavior we want; if so, let's do that. If it turns out we can't, then so be it! Thanks @btejha!

@btejha btejha closed this Dec 3, 2024
@btejha btejha deleted the 10549-design-debt-intermediate-branch-to-test-1733176098 branch December 3, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants