-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
10293 to test: use unique React key in PendingReportList.tsx #5630
Merged
akuny
merged 12 commits into
ustaxcourt:test
from
flexion:10293-design-debt-intermediate-branch-to-test-1732629359
Dec 10, 2024
Merged
10293 to test: use unique React key in PendingReportList.tsx #5630
akuny
merged 12 commits into
ustaxcourt:test
from
flexion:10293-design-debt-intermediate-branch-to-test-1732629359
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akuny
changed the title
10293 design debt intermediate branch to test 1732629359
10293 to test: use unique React key in PendingReportList.tsx
Dec 6, 2024
Mwindo
reviewed
Dec 10, 2024
web-client/src/presenter/actions/PendingItems/setPendingItemsAction.test.ts
Outdated
Show resolved
Hide resolved
TomElliottFlexion
approved these changes
Dec 10, 2024
Mwindo
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @akuny!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
10293
Initially,
PendingReportList.tsx
used the following React key implementation:This approach failed to uniquely identify each rendered item, so the key was updated to the following:
During testing, this updated key also failed to ensure uniqueness.
This PR uses
pending-item-${item.docketNumber}-${item.docketEntryId}
as the React key for the pending report.