Modify restoreDbFromSource to drop all target tables before restore #5642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mwindo
commented
Dec 10, 2024
| @@ -215,8 +215,61 @@ async function restoreFromBackup({ | |||
| }); | |||
| const targetPassword = await targetSigner.getAuthToken(); | |||
|
|
|||
| // pg_restore only drops tables in the dump, so we drop all tables before pg_restore. | |||
There was a problem hiding this comment.
This script file is getting long/clumsy. I will see if there are easy ways to simplify in the near future.
jimlerza
approved these changes
Dec 20, 2024
jimlerza
deleted the
restoreDbFromSource-drop-all-target-tables-before-restore
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current implementation of
restoreDbFromSourceonly drops and re-creates tables in our target db that exist in ourpg_dump. Instead, we want a clean slate in our target db.We could drop and re-create the target database or drop and re-create the target schema, but both of these involve dealing with stricter permissions. Instead, the approach in this PR is to query for all of the tables from the target schema and drop them.