-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DevEx: Implement the argument parser in our typescript scripts #5654
Conversation
…o use the parseArguments helper
…rseArguments helper
…for fetching environment variables
…sAndEnvironmentVariables
…sAndEnvironmentVariables
…use parseArgumentsAndEnvironmentVariables
… bring branch coverage to 100
… in parseArgsAndEnvVars
…uses a permanent IAM key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good and helps us standardize how we run our scripts. Thank you for cleaning all of this up. Big fan.
Personally, I think that handling the argument parsing should be done by a package rather than rolling our own, or custom functionality like "requireActiveAwsSession" be built on top of a package. Maintaining our own arg parser does not seem valuable to me, however I recognize the court is the one who uses scripts far more often than Flexion so trust your judgement and needs more than my own. Definitely not a show stopper but wanted to be direct.
…on-served-in-drafts.helpers
…into a helpers file and adjusted the imports accordingly
Argument parsing is done by This is a follow-up PR which implements that wrapper in the scripts. The original PR was just the wrapper and its tests. |
See #5606 for the fancy marketing blahblah
Successful migration deployment