10536: Fix messages jumping when clicking message complete checkbox; #5829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ple cases in order to test sorting, so these tests were not doing anything.
jimlerza
approved these changes
Feb 26, 2025
nechama-krigsman
approved these changes
Feb 28, 2025
JayFlexy
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sorting in descending order, the function first sorts the array and then reverses it using array.reverse(). When a checkbox is clicked, it the data is reversed for messages that have the same docket number.
This PR removes the double sort, and handles it inside of a single sort function and does not change the order of the list if the fields are the same.