Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

devex: fix to allow circle to deploy the stale case lambda #5844

Merged
merged 3 commits into from
Feb 28, 2025
Merged

devex: fix to allow circle to deploy the stale case lambda #5844

merged 3 commits into from
Feb 28, 2025
+31 −22

Conversation

jimlerza
Copy link
Collaborator

@jimlerza jimlerza commented Feb 28, 2025 •
edited
Loading

2 fixerinos:

  1. Don't require the EMAIL_SOURCE env var (it's not in secrets manager).
  2. Add the stale_cases_email_cron_lambda_role to the list of IAM resources that the CircleCI user can manipulate.

Successful deployment on exp1

@jimlerza jimlerza merged commit 95c8430 into staging Feb 28, 2025
87 of 90 checks passed
@jimlerza jimlerza deleted the devex-circle-deploy-stale-case-lambda-fix branch February 28, 2025 17:38
@jimlerza jimlerza mentioned this pull request Feb 28, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@En-8 En-8 En-8 approved these changes

@nechama-krigsman nechama-krigsman nechama-krigsman approved these changes

Assignees
No one assigned
Labels
Needs Account Specific to staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimlerza @En-8 @nechama-krigsman