Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "deb" Makefile target #84

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Add "deb" Makefile target #84

merged 3 commits into from
Jul 23, 2024

Conversation

iBug
Copy link
Member

@iBug iBug commented Jul 23, 2024

No description provided.

@taoky
Copy link
Member

taoky commented Jul 23, 2024

在 post-install 环节可以自动重启 yukid 吗?

@iBug
Copy link
Member Author

iBug commented Jul 23, 2024

在 post-install 环节可以自动重启 yukid 吗?

这不一定是个好主意?

@taoky
Copy link
Member

taoky commented Jul 23, 2024

在 post-install 环节可以自动重启 yukid 吗?

这不一定是个好主意?

如果 yukid 已经在运行的话,cp 可能会失败吧。

@iBug
Copy link
Member Author

iBug commented Jul 23, 2024

如果 yukid 已经在运行的话,cp 可能会失败

不会,dpkg 安装的时候用的是类似 install(1) 的方法,不是直接写入正在运行的程序文件(否则会 ETXTBSY)。Makefile 里的 cp 命令仅用于在 build 目录下放着好目录结构。

@iBug iBug force-pushed the deb branch 2 times, most recently from 74551bc to 4a245a5 Compare July 23, 2024 14:29
@iBug iBug merged commit 76f16f5 into main Jul 23, 2024
3 checks passed
@iBug iBug deleted the deb branch July 23, 2024 15:26
Comment on lines +59 to +62
- uses: softprops/action-gh-release@v1
with:
files: |
yuki*.deb
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好主意,那么 prefix 要不要从 /usr/local 换到 /usr

(既然我们都在用 package manager 了,可以考虑遵循 FHS)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🉑 我觉得挺好的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants