Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added error checking for element instance #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timwright12
Copy link

This was throwing an error for me if there wasn't a UStream player on the page, so I added so checks for those of us who like concatenating all scripts

@necccc
Copy link
Contributor

necccc commented Jan 9, 2015

The code looks ok, the reason is what confuses me.

How exactly the error happen?
If the error occured because create instance was called without the player element, why was it called?
"Concatenating scripts" itself should not result in an error (we use this lib all the time packed with other scripts), the affected code only runs if you invoke it by creating a new instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants