fix/helper: Fix dealloc_c_utf8_alloced_from_rust #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation assumed `Vec::shrink_to_fit` would always make Vec's length equal to its capacity. However, there was no such guarantee and undefined behaviour could be triggered. Currently Rust implementation assume this as well. A proper fix would use boxed slices so we don't need to store capacity. We may want to revisit this as the following Rust issue gets more attention: rust-lang/rust#36284
The previous approach was being used out of concern over the FFI barrier. However, `size_t` is broadly available and can be used safely.
`low_level_api::misc::misc_u8_ptr_free` should be enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation assumed
Vec::shrink_to_fitwould always makeVec's length equal to its capacity. However, there was no such guarantee
and undefined behaviour could be triggered.
Currently Rust implementation assume this as well. A proper fix would
use boxed slices so we don't need to store capacity.
We may want to revisit this as the following Rust issue gets more
attention: rust-lang/rust#36284