Add configurable listener ALPN protocols to enable downstream http2 #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laurent Marchaud <laurent@marchaud.com>
Signed-off-by: Laurent Marchaud <laurent@marchaud.com>
|
Marking this PR as draft as envoy has issues with http2 connection coalescing, leading to 404s. See envoyproxy/envoy#6767 We could add a lua script to respond with a 421 when a connection is being used for the wrong host, like Contour did: projectcontour/contour#2483 |
|
I hope that issued gets resolved, I'd love to get Downstream HTTP/2 enabled as well. I'll give the Lua solution a peek as well though I can't say I'm Lua proficient 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No breaking change, listener offers no ALPN protocol by default.