パラメータの微修正 #56
Merged
パラメータの微修正 #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
200km
requested review from
seki-hiro,
suzuki-toshihir0 and
conjikidow
and removed request for
a team
200km
added
🚀 priority::high
seki-hiro
reviewed
Aug 11, 2023
Comment on lines
+25
to
+27
| constant_bias_c_rad_s(0) = -0.0180004966 | ||
| constant_bias_c_rad_s(1) = -0.00919875782 | ||
| constant_bias_c_rad_s(2) = 0.0208997503 |
There was a problem hiding this comment.
[Q] これは運用での推定結果の一つでしょうか？元々の値がメーカーの示すスペックであれば、そちらを使い続けた方がいいのかなと思いました。
There was a problem hiding this comment.
元々の値がメーカーの示すスペックはなく、実機で測定する必要があります。また、個体差が結構大きいです。
この値自体の出所はわかりませんが、C2A側のデフォルト値に合わせています。
There was a problem hiding this comment.
C2A側と合っていなかったということですね。わかりました。
seki-hiro
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
NA
詳細
C2Aの下記PRとパラメータを合わせるための修正
ut-issl/c2a-aobc#163
検証結果
NA
補足
NA
注意
Reviewersを設定することAssigneesを自分自身に割り当てることProjectsとして6U AOCS team (private)を設定するStatusをWaiting Reviewに設定するpriorityラベルを付けることupdateラベルをつけることNAと書き換えたりする