Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] Remove enhanced comment and preceding whitespace from str… #577

Merged

Conversation

suzuki-toshihir0
Copy link
Member

@suzuki-toshihir0 suzuki-toshihir0 commented Jan 19, 2024

Related issues

Description

Details on Bug & Cause of Bug

Treatment in thir PR

  • Strings like some blanc characters(including whitespaces or tabs) + "//" + any characters are removed in IniAccess::ReadString .

Test results

image (3)

Impact

  • Large (Windows user only): We cannot conduct verification related to ECI <--> ECEF transformation.

Supplementary information

  • N/A

@suzuki-toshihir0 suzuki-toshihir0 added priority::high priorityg high patch backwards compatible bug fixes labels Jan 19, 2024
@suzuki-toshihir0 suzuki-toshihir0 self-assigned this Jan 19, 2024
@suzuki-toshihir0 suzuki-toshihir0 requested review from sksat and a team as code owners January 19, 2024 12:05
@suzuki-toshihir0 suzuki-toshihir0 requested review from 200km, t-hosonuma and conjikidow and removed request for a team January 19, 2024 12:05
Copy link
Member

@200km 200km left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます。念の為、私のclang環境でも試験しましたが、問題なく実行できました。

@200km 200km linked an issue Jan 19, 2024 that may be closed by this pull request
2 tasks
@suzuki-toshihir0
Copy link
Member Author

ご確認いただきありがとうございます!

@suzuki-toshihir0 suzuki-toshihir0 merged commit 6385e16 into main Jan 19, 2024
11 checks passed
@suzuki-toshihir0 suzuki-toshihir0 deleted the hotfix/handle_enhanced_comment_for_string_in_ini branch January 19, 2024 12:29
suzuki-toshihir0 added a commit that referenced this pull request Jan 19, 2024
Merge main to develop for HOTFIX #577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch backwards compatible bug fixes priority::high priorityg high
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

.ini file read error for Windows Visual Studio users
2 participants