Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Urf 6 refactor all #5

Merged
merged 18 commits into from
Jul 12, 2024
Merged

Urf 6 refactor all #5

merged 18 commits into from
Jul 12, 2024

Conversation

Jeff92316046
Copy link
Contributor

@Jeff92316046 Jeff92316046 commented Jun 26, 2024 •
edited
Loading

refactor all page to component and pull out api

page divide to component

  • from
  • timetable
  • (verify)暫時不需要

pull out api

  • reserve(post,put,del,get)
  • items
  • spaces
  • item_available_time
  • space_available_time
  • verify

@linear Linear
Copy link

linear bot commented Jun 26, 2024

URF-6 vue風格重構程式碼

@Jeff92316046 Jeff92316046 self-assigned this Jun 26, 2024
nickchengtw
nickchengtw requested changes Jun 26, 2024
View reviewed changes
src/components/form/ItemShower.vue Outdated Show resolved Hide resolved
src/components/form/SpaceShower.vue Outdated Show resolved Hide resolved
src/components/form/SubmitDialog.vue Outdated Show resolved Hide resolved
src/components/form/SubmitDialog.vue Outdated Show resolved Hide resolved
nickchengtw
nickchengtw requested changes Jun 26, 2024
View reviewed changes
src/components/form/ItemShower.vue Outdated Show resolved Hide resolved
src/components/form/SpaceShower.vue Outdated Show resolved Hide resolved
@Jeff92316046
Copy link
Contributor Author

我用timetable試了一下vuetify的table元件
可以看一下

@nickchengtw nickchengtw mentioned this pull request Jun 28, 2024
Closed
@Jeff92316046 Jeff92316046 linked an issue Jun 28, 2024 that may be closed by this pull request
使用Vuetify的table元件取代自製的表格 #6
Closed
@Jeff92316046
Copy link
Contributor Author

有一些垃圾命名可以再跟我講🤣

@nickchengtw

This comment was marked as resolved.

Sign in to view
@Jeff92316046
Copy link
Contributor Author

這個應該有很多問題，可以討論一下
我也不知道怎麼寫比較好
我是參考這篇https://ithelp.ithome.com.tw/articles/10263166
也有看一下請假系統的架構
如果要改的東西太多也可以再開個branch出去，感謝

nickchengtw
nickchengtw reviewed Jul 1, 2024
View reviewed changes
.env Outdated Show resolved Hide resolved
@nickchengtw
Copy link

這個應該有很多問題，可以討論一下 我也不知道怎麼寫比較好 我是參考這篇https://ithelp.ithome.com.tw/articles/10263166 也有看一下請假系統的架構 如果要改的東西太多也可以再開個branch出去，感謝

看起來沒什麼大問題
可以先用他的方法

@Jeff92316046
Copy link
Contributor Author

串接的部分再額外用就好，有些api還沒生出來所以也沒辦法測試

@Jeff92316046 Jeff92316046 merged commit 27788f2 into main Jul 12, 2024
@Chun-Cheng Chun-Cheng deleted the urf-6-refactor-all branch December 6, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickchengtw nickchengtw nickchengtw approved these changes

@HaBiOwO HaBiOwO Awaiting requested review from HaBiOwO

Assignees

@Jeff92316046 Jeff92316046

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

使用Vuetify的table元件取代自製的表格
2 participants
@Jeff92316046 @nickchengtw